fix(ui): Run type-check on build by dstaley · Pull Request #8076 · clerk/javascript

dstaley · 2026-03-13T19:04:24Z

Description

This PR enables type checking for the ui package during build, which previously wasn't being run. It also makes several TypeScript fixes to resolve errors.

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

Bug Fixes
- Fixed minor TypeScript type issues to improve runtime reliability and modal behavior
Chores
- Added type-checking to the build pipeline
- Strengthened type-safety across payment, subscription, and modal flows
- Allowed null defaults for organization creation inputs for more flexible handling
- Excluded test sources from TypeScript compilation to streamline configs

vercel · 2026-03-13T19:04:31Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	Mar 18, 2026 9:52pm

changeset-bot · 2026-03-13T19:04:33Z

🦋 Changeset detected

Latest commit: 2f2f938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-03-13T19:07:26Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8076

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8076

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8076

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8076

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8076

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8076

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8076

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8076

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8076

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8076

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8076

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8076

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8076

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8076

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8076

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8076

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8076

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8076

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8076

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8076

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8076

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8076

commit: 2f2f938

coderabbitai · 2026-03-13T19:09:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4d4e5ef-e3ed-4120-8ae0-58542e1b6c3d

📥 Commits

Reviewing files that changed from the base of the PR and between e99e1ef and 2f2f938.

📒 Files selected for processing (2)

packages/ui/package.json
packages/ui/src/components/SubscriptionDetails/index.tsx

📝 Walkthrough

Walkthrough

Adds a changeset and updates the @clerk/ui package build script to run a type-check step. Renames several modal prop types (e.g., SignInProps → SignInModalProps) and adds UserProfileModalProps; updates ComponentsState accordingly. Provides safe defaults for modal getContainer usages. Introduces non-null assertions for plan.fee/annualFee in multiple pricing, subscription, checkout, and payment components. Expands some prop types to accept null, removes a local import, and adds "./src/test/**" to tsconfig exclude.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the primary change: enabling type-check during the build process for the UI package, which is the main objective of this PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

dstaley added 8 commits March 13, 2026 13:23

chore(ui): Add type-check to build step

5c01f8a

fix(ui): Type getContiner correctly

fa518b4

fix(ui): assert non-null fee when planPeriod is monthly

42302db

fix(ui): Allow null organizationCreationDefaults

56f854d

fix(ui): cast as type

4e20220

fix(ui): remove unused import

699d2d2

chore(ui): Ignore typechecking in test folder

3b620a1

chore(repo): Add changeset

e99e1ef

dstaley requested a review from LauraBeatris March 13, 2026 19:04

dstaley changed the title ~~fix(ui):~~ fix(ui): Run type-check on build Mar 13, 2026

github-actions bot added the ui label Mar 13, 2026

LauraBeatris approved these changes Mar 13, 2026

View reviewed changes

Merge branch 'main' into ds.fix/typecheck-ui

2f2f938

vercel bot deployed to Preview March 18, 2026 21:52 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): Run type-check on build#8076

fix(ui): Run type-check on build#8076
dstaley wants to merge 9 commits intomainfrom
ds.fix/typecheck-ui

dstaley commented Mar 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 13, 2026 •

edited

Loading

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dstaley commented Mar 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

vercel bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dstaley commented Mar 13, 2026 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 13, 2026 •

edited

Loading

changeset-bot bot commented Mar 13, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 13, 2026 •

edited

Loading

coderabbitai bot commented Mar 13, 2026 •

edited

Loading